[HttpFoundation] Allow array style callable setting for Request setFactory method #54333
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| if(null === $callable) { | ||
| self::$requestFactory = null; | ||
| return; | ||
| } | ||
|
|
||
| self::$requestFactory = $callable(...); |
There was a problem hiding this comment.
We usually use a ternary expression when resolving this kind of union.
| if(null === $callable) { | |
| self::$requestFactory = null; | |
| return; | |
| } | |
| self::$requestFactory = $callable(...); | |
| if(null === $callable) { | |
| self::$requestFactory = null; | |
| return; | |
| } | |
| self::$requestFactory = null === $callable ? null : $callable(...); |
|
Good catch, thanks @jan-simbera. |
Allowing to use the array notation for callback for the setFactory static method of the request.
Unit test added to confirm bug/fixing the bug.