10000 [DependencyInjection] unable to make lazy service from readonly class by kor3k · Pull Request #53877 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[DependencyInjection] unable to make lazy service from readonly class #53877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[DependencyInjection] unable to make lazy service from readonly class #53877

wants to merge 1 commit into from

Conversation

kor3k
Copy link
Contributor
@kor3k kor3k commented Feb 8, 2024
Q A
Branch? 7.0
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53843.
License MIT

@OskarStark
Copy link
Contributor

Why this PR?
#53876 should be enough, right?
We will upmerge the bugfix to higher branches anyway

@kor3k
Copy link
Contributor Author
kor3k commented Feb 9, 2024

@OskarStark yes, that one is enough. but i noticed that in the 7 branch that the checks PHP_VERSION_ID >= 80200 are missing as they're redundand. so this PR is exactly the same as #53876 just without the check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DependencyInjection] unable to make lazy service from readonly class
4 participants
0