[FrameworkBundle] added ContainerAwareInterface to services.xml #535
Conversation
|
Sorry, I didnt realize this before. Now leads to I guess we should ensure that interface setters are either called first or better yet we need to remove redundant calls? |
|
The following patch fixes the issue, basically it will not add a method call via interface injection if the method has already been explicitly set: I am not sure if there is a sane use case where one would want to do multiple method calls via interface injection. |
|
Your patch looks good to me. Can you send a PR? |
|
@lsmith77 could we imagine something like a |
|
done here #541 |
|
Well in this particular case the point is to "fix" the hardcoded dependency set by the interface injection. |
|
Dependency injection is all about being able to inject what you want. Implementing an interface is a way for the class to ask for some dependencies, but final control over this should always be with the end user using the class and not with the class itself. |
No description provided.