8000 [Cache] Fix CI failing tests by alexandre-daubois · Pull Request #53124 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Fix CI failing tests #53124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service 8000 and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

[Cache] Fix CI failing tests #53124

merged 1 commit into from
Dec 18, 2023

Conversation

alexandre-daubois
Copy link
Member
@alexandre-daubois alexandre-daubois commented Dec 18, 2023 •
edited
Loading
Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Fixes CI, AbstractAdapter::createConnection checks the bucket support before falling back to Collection when the DSN starts with couchbase. Should fix CI in all versions with #53054

@carsonbot carsonbot added this to the 7.1 milestone Dec 18, 2023
@alexandre-daubois alexandre-daubois force-pushed the fix-deprec-warning branch 2 times, most recently from c9388c6 to a385bc4 Compare December 18, 2023 10:30
@alexandre-daubois alexandre-daubois changed the title [Cache] Fix failing test [Cache] Fix failing tests Dec 18, 2023
@alexandre-daubois alexandre-daubois changed the title [Cache] Fix failing tests [Cache] Fix CI failing tests Dec 18, 2023
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit f62c869 into symfony:7.1 Dec 18, 2023
@derrabus derrabus mentioned this pull request May 17, 2024
Merged
fabpot added a commit that referenced this pull request May 21, 2024
@fabpot
bug #54979 [Cache] Fix irrelevant deprecation when connecting to Couc…
e38be3a 
…hbase (derrabus)

This PR was merged into the 7.1 branch.

Discussion
----------

[Cache] Fix irrelevant deprecation when connecting to Couchbase

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | Follows #53124
| License       | MIT

When creating a connection for Couchbase, we currently always trigger a deprecation that we cannot opt out of. The reason is that `AbstractAdapter` calls the the `isSupported()` method of the deprecated `CouchbaseBucketAdapter` class before deciding in favor of its non-deprecated replacement `CouchbaseCollectionAdapter`.

Commits
-------

817420f [Cache] Fix CouchbaseCollectionAdapterTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-daubois @nicolas-grekas @carsonbot
0