[AssetMapper] Improve link generation script #52869
Conversation
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 ?". Cheers! Carsonbot |
|
let's do this on 6.4 as a bugfix |
| @@ -92,7 +92,8 @@ public function testBasicRender() | |||
| $this->assertStringContainsString('"app_css_preload": "data:application/javascript,', $html); | |||
| $this->assertStringContainsString('<link rel="stylesheet" href="/subdirectory/assets/styles/app-preload-d1g35t.css">', $html); | |||
| // non-preloaded CSS file | |||
| $this->assertStringContainsString('"app_css_no_preload": "data:application/javascript,const%20d%3Ddocument%2Cl%3Dd.createElement%28%22link%22%29%3Bl.rel%3D%22stylesheet%22%2Cl.href%3D%22%2Fsubdirectory%2Fassets%2Fstyles%2Fapp-nopreload-d1g35t.css%22%2C%28d.head%7C%7Cd.getElementsByTagName%28%22head%22%29%5B0%5D%29.appendChild%28l%29', $html); | |||
| // $this->assertStringContainsString('"app_css_no_preload": "data:application/javascript,document.head.appendChild(Object.assign(document.createElement("link"),{rel:"stylesheet",href:"/subdirectory/assets/styles/app-nopreload-d1g35t.css"})', $html); | |||
There was a problem hiding this comment.
why this commented line ?
The deleted was the old test
The new "commented" line is the humanely readable version of the new test the following line.
You do feel it's useless ?
There was a problem hiding this comment.
yes it is, a commented line like this one is not useful for humans (and even less for computers)
|
looks like a rebase is missing :) |
76788f3 to
0d7fcb7
Compare
Dropped all commits but mine.. I have this special power to destroy git histories like no-one.. so please double-check i've not done anything wrong there 😅 |
0d7fcb7 to
5ad7a1e
Compare
|
Thank you @smnandre. |
Avoid JS console warnings due to missing comma and shorten a bit the code
(document.head is available since IE9)
Felt on it while investigating this HTTPS/2/Push thing with Firefox
(poke @weaverryan)
Update: remove the "?" after 7.1 to please carson :)
Update(bis): target 6.4 / bugfix