[Cache] Fix return type of Redis6Proxy::mget()
#52700
Conversation
|
Did yo confirm the extension can return false? |
|
Yes, I can confirm the extension can return
Tested on PHP 8.2, Redis Extension 6.0.2 Shouldn't we provide a fix of this kind to comply to what the extension actually does? Or are you 👎 on this one because of the potential maintenance cost maybe? (this case makes me think of this comment) |
|
I'd like to see the pressure on this issue go from this repo to the source one yes. Sending fixes, etc ;) |
PHP extensions don't need to follow their own signatures, confirmed in Slack with @alcaeus |
I'll add a clarification to that: the type of a value returned in an extension method is only checked when PHP has been compiled with debug symbols. When not running in debug mode, extension developers are trusted to "not do stupid things" and return only values that conform to the method signature. I absolutely agree that this is an upstream issue that needs fixing. |
|
I am currently trying to work on a fix on the extension. Will link this in the issue, closing for now 👍 Thank you for all your answers! |
|
For the record: phpredis/phpredis#2422 |
After @dkarlovi's comment, here is another try that will not break returns types. Thank you for taking the time to explain where the exact problem is, Dalibor 👍
Todo: having a look at failing tests