8000 [Messenger] Fix WrappedExceptionsTrait by chalasr · Pull Request #51801 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Fix WrappedExceptionsTrait #51801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2023
Merged

[Messenger] Fix WrappedExceptionsTrait #51801

merged 1 commit into from
Oct 2, 2023

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented Oct 2, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT

Fixes some minor flaws introduced in #51653

@carsonbot carsonbot added this to the 6.4 milestone Oct 2, 2023
chalasr
chalasr commented Oct 2, 2023
View reviewed changes
src/Symfony/Component/Messenger/Exception/WrappedExceptionsTrait.php
@@ -18,6 +18,8 @@
*/
trait WrappedExceptionsTrait
{
private array $exceptions;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of assuming that the property exists on use-ing classes

@chalasr chalasr force-pushed the msg-fix-wrapped-exceptions branch from 06d8e9d to 8c3f124 Compare October 2, 2023 12:54
@chalasr chalasr changed the title [Messenger] Fix WrappedExceptionsTrait & tests [Messenger] Fix WrappedExceptionsTrait Oct 2, 2023
@chalasr chalasr force-pushed the msg-fix-wrapped-exceptions branch from 8c3f124 to f7242ca Compare October 2, 2023 12:55
@fabpot
Copy link
Member
fabpot commented Oct 2, 2023

Thank you @chalasr.

@fabpot fabpot merged commit a257327 into symfony:6.4 Oct 2, 2023
@chalasr chalasr deleted the msg-fix-wrapped-exceptions branch October 2, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @fabpot @carsonbot
< 3192 div hidden> Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
0