[Messenger] Add support for multiple Redis Sentinel hosts #51687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e13640 to
578a794
Compare
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/RedisExtIntegrationTest.php
Outdated
Show resolved
Hide resolved
578a794 to
3380518
Compare
|
Thank you @digilist. |
|
@digilist there are some failures on our integration tests that might be related to this PR. Would you have some availability to have a look please? 🙏 |
|
Yes, sure. It looks like a merge conflict between #51683 and this PR was resolved incorrectly, as there are now two connection attempts to Sentinel: symfony/src/Symfony/Component/Cache/Traits/RedisTrait.php Lines 226 to 253 in 3c4cfbd I'll provide a PR. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 28, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [Cache] Fix two initializations of Redis Sentinel | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT After #51687 and #51683 have been merged, there are now two initializations of Redis Sentinel, which also leads to the integration test failure mentioned in [this comment](#51687 (comment)). This PR fixes this. Commits ------- 2d23a1b [Cache] Fix two initializations of Redis Sentinel
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #47003 which added support for multiple Redis Sentinel hosts for the Cache component, this PR adds support for multiple Sentinel hosts for the Messenger component.
This PR is inspired by the implementation in the cache component and works very similar. A DSN could look like this:
redis:?host[localhost:26377]&host[localhost:26379]&sentinel_master=db.I changed the Sentinel host environment variable for the ingegration to an invalid host at. As a result I noticed that Relay also fails in such case and so I expanded my earlier changes from #51598 to also ignore unreachable hosts with the Relay extension.