8000 [Messenger] Add the `--all` option to the `messenger:failed:remove` command by alexandre-daubois · Pull Request #51593 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Add the --all option to the messenger:failed:remove command #51593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for Git 8000 Hub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

[Messenger] Add the --all option to the messenger:failed:remove command #51593

merged 1 commit into from
Sep 29, 2023

Conversation

alexandre-daubois
Copy link
Member
@alexandre-daubois alexandre-daubois commented Sep 7, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR Todo

We have a development server (which we don't have direct access to the database). As this server serves as a test for our devs, error messages can accumulate in our failure transport. We wanted to use the messenger:failed:remove command to remove them, but unfortunately, we must provide ids individually. This is problematic as we have several hundreds of failed messages.

This PR adds the --all option to the command. This option must be used with the --force option (juste like doctrine:schema:update --force actually) to work. Example output:

$ bin/console messenger:failed:remove --all --force

...

Failed Message Details
======================
                                                                                                                        
 [WARNING] Message does not appear to have been sent to this transport after failing                                    
                                                                                                                        
 ------------ ------------------------- 
  Class        App\Message\YourMessage  
  Message Id   6                        
 ------------ ------------------------- 

 ! [NOTE] 4 messages were removed.

As you can see, you can of course still use the --show-messages option jointly.

8000 @carsonbot carsonbot added this to the 6.4 milestone Sep 7, 2023
8000
@alexandre-daubois alexandre-daubois force-pushed the remove-all-failed-msgs branch from 0c6d6e1 to 12d9ad0 Compare September 18, 2023 07:26
@alexandre-daubois
Copy link
Member Author

All comments addressed, thanks! 🙂

nicolas-grekas
nicolas-grekas reviewed Sep 19, 2023
View reviewed changes
@alexandre-daubois
Copy link
Member Author

Addressed all your comments Nicolas, thank you!

@alexandre-daubois alexandre-daubois force-pushed the remove-all-failed-msgs branch 2 times, most recently from f26d36b to b674207 Compare September 19, 2023 14:08
@alexandre-daubois alexandre-daubois force-pushed the remove-all-failed-msgs branch 2 times, most recently from 7d62d21 to 322d892 Compare September 21, 2023 06:57
@nicolas-grekas
Copy link
Member

Thank you @alexandre-daubois.

@nicolas-grekas nicolas-grekas merged commit 4b21e21 into symfony:6.4 Sep 29, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 29, 2023
Closed
@alexandre-daubois alexandre-daubois deleted the remove-all-failed-msgs branch September 30, 2023 06:38
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic left review comments

@fabpot fabpot fabpot requested changes

@kbond kbond kbond approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@alexandre-daubois @nicolas-grekas @fabpot @kbond @welcoMattic @carsonbot
0