8000 [FrameworkBundle] Always use buildDir as `ConfigBuilderGenerator` outputDir by HypeMC · Pull Request #51588 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Always use buildDir as ConfigBuilderGenerator outputDir #51588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2023
Merged

[FrameworkBundle] Always use buildDir as ConfigBuilderGenerator outputDir #51588

merged 1 commit into from
Sep 27, 2023

Conversation

HypeMC
Copy link
Member
@HypeMC HypeMC commented Sep 6, 2023
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51582
License MIT
Doc PR -

The ConfigBuilderGenerator is instantiated in three places, two of which use kernel.build_dir as the output dir, and one which uses kernel.cache_dir:

This PR fixes this inconsistency so that kernel.build_dir is always used.

@carsonbot carsonbot added this to the 5.4 milestone Sep 6, 2023
@HypeMC HypeMC mentioned this pull request Sep 6, 2023
Closed
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit f8e2aa2 into symfony:5.4 Sep 27, 2023
@HypeMC HypeMC deleted the fix-configbuildercachewarmer-outputdir branch September 27, 2023 14:09
This was referenced Sep 30, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@HypeMC @nicolas-grekas @carsonbot
0