8000 [Templating] deprecate the component by kbond · Pull Request #51144 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Templating] deprecate the component #51144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll 8000 occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

[Templating] deprecate the component #51144

merged 1 commit into from
Jul 30, 2023

Conversation

kbond
Copy link
Member
@kbond kbond commented Jul 28, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets n/a
License MIT
Doc PR n/a

I think it's time to deprecate/remove this component.

@carsonbot carsonbot added this to the 6.4 milestone Jul 28, 2023
@kbond
Copy link
Member Author
kbond commented Jul 28, 2023

I'm not sure how to suppress the deprecations. I've added @group legacy to the test classes but I guess the deprecations are triggered earlier?

@GromNaN
Copy link
Member
GromNaN commented Jul 28, 2023 •
edited
Loading

The component is still downloaded 30K/day. Not on legacy projects since there is 6.4K daily installs for the v6.
image

@kbond
Copy link
Member Author
kbond commented Jul 28, 2023

I think a good chunk of the downloads are transient. For instance, knplabs/knp-time-bundle requires it and has ~4k daily downloads.

This was referenced Jul 28, 2023
Merged
Closed
@nicolas-grekas
Copy link
Member

👍 for the proposal. Deprecating it will still mean maintaining it for the duration of the LTS, so 3 more years.

@nicolas-grekas
Copy link
Member

Any corresponding config tree in frameworkbundle that should also be deprecated?

@derrabus
Copy link
Member

Any corresponding config tree in frameworkbundle that should also be deprecated?

Didn't this happen in #32267 already?

@fabpot
Copy link
Member
fabpot commented Jul 30, 2023

Thank you @kbond.

@fabpot fabpot force-pushed the deprecate-templating branch from afd830d to 2a07431 Compare July 30, 2023 13:03
@fabpot fabpot merged commit c2ee867 into symfony:6.4 Jul 30, 2023
@fabpot fabpot mentioned this pull request Jul 30, 2023
Closed
This was referenced Aug 3, 2023
Merged
Closed
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Deprecation Status: Reviewed Templating
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@kbond @GromNaN @nicolas-grekas @derrabus @fabpot @carsonbot
0