8000 [Validator] Deprecate annotations in favor of attributes by derrabus · Pull Request #50982 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Validator] Deprecate annotations in favor of attributes #50982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

[Validator] Deprecate annotations in favor of attributes #50982

merged 1 commit into from
Jul 24, 2023

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Jul 14, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Follows #50888
License MIT
Doc PR symfony/symfony-docs#18589

This PR deprecates using Doctrine annotations to configure validation constraints. Attributes shall be used instead.

Existing applications can be migrated easily using Rector.

Deprecation errors triggered by the bundles' functional tests will be resolved once #50888 is merged.

@carsonbot carsonbot added this to the 6.4 milestone Jul 14, 2023
@derrabus derrabus force-pushed the deprecate/validator-annotations branch 3 times, most recently from 8b51e8e to 25b0e99 Compare July 14, 2023 19:35
This was referenced Jul 14, 2023
Merged
Closed
@derrabus derrabus force-pushed the deprecate/validator-annotations branch 3 times, most recently from ac6c303 to 064d470 Compare July 20, 2023 17:26
@derrabus derrabus requested a review from nicolas-grekas July 20, 2023 18:51
nicolas-grekas
nicolas-grekas reviewed Jul 21, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mind fabbot, it has useful hints

@derrabus
Copy link
Member Author

please mind fabbot, it has useful hints

The fact that it does not want me to fully qualify a method_exists() call always puzzles me. 🤷🏻‍♂️

@derrabus derrabus force-pushed the deprecate/validator-annotations branch 2 times, most recently from 5c0ec57 to 4fc3e7e Compare July 22, 2023 23:35
@nicolas-grekas nicolas-grekas force-pushed the deprecate/validator-annotations branch from 4fc3e7e to 6b6dc62 Compare July 24, 2023 06:37
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 8e36ac6 into symfony:6.4 Jul 24, 2023
@derrabus derrabus deleted the deprecate/validator-annotations branch July 24, 2023 07:07
@derrabus derrabus mentioned this pull request Jul 24, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Jul 24, 2023
@nicolas-grekas
feature #51085 [Validator] Remove Doctrine annotations support (derra…
ffe6f08 
…bus)

This PR was merged into the 7.0 branch.

Discussion
----------

[Validator] Remove Doctrine annotations support

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Follows #50982
| License       | MIT
| Doc PR        | symfony/symfony-docs#18589

Commits
-------

d18dfa5 [Validator] Remove Doctrine annotations support
@derrabus derrabus mentioned this pull request Jul 27, 2023
Closed
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Deprecation Feature Status: Needs Review Validator
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @nicolas-grekas @carsonbot
0