[FrameworkBundle] Fixed parsing new JSON output of debug:config not possible #50637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The title should be only for the text format IMO |
|
There is no text format. The default is |
|
then maybe the title should be removed or be an info written to stderr instead of stdout |
|
I don't really see any value in the title either but I don't feel like I'm in charge to decide on this 😄 |
|
maybe show title if --format is not given or put different, the default format can be new |
|
I like that suggestions so I've quickly implemented a first version - wdyt? |
nicolas-grekas
approved these changes
Jun 21, 2023
fabpot
approved these changes
Jun 24, 2023
26ebc65 to
a3e8560
Compare
|
Thank you @Toflar. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my comment to the original PR which introduced
debug:config --format=json: #48457 (comment)Currently, it's not possible to parse the JSON output (neither is the YAML) which makes
--format=jsonkind of pointless. The argument against this - I guess - is that the JSON format was introduced to make the command independent from the YAML component but still, why is--formatan option then?So I guess by delivering an additional option, we can fix this issue and make it parsable.
(Maybe instead of having
--no-tiltewe should call itparsablein the first place so that if in the future there's something on top of the title, the option would still be valid?)