[Scheduler] Allow setting cron expression next run date timezone #50572
Conversation
There was a problem hiding this comment.
Thanks @danielburger1337, this looks good to me.
It will need to be against 6.4 though. Experimental just means we may/can introduce BC breaks in 6.4 but other than that, the process for new features remains the same.
Could you add a simple test that proves the timezone is being used?
This would be in the Scheduler |
|
I am even worse at using git than I thought. 😒 I think the rebase worked in the end but for some reason GitHub automatically requested a review from a bunch of people. |
|
No worries, I've seen that a lot lately with PR's being updated from 6.3 to 6.4. I don't think there's a way to avoid. |
src/Symfony/Component/Scheduler/Tests/Trigger/CronExpressionTriggerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Tests/Trigger/CronExpressionTriggerTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Trigger/CronExpressionTrigger.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Scheduler/Trigger/CronExpressionTrigger.php
Outdated
Show resolved
Hide resolved
|
Thank you @danielburger1337. |
Allow setting the timezone for the next run date derived from a cron expression.
This is my first contribution to an experimental component and therefor I am not familiar with the exact contribution guidelines.
As this component is experimental, I think it is ok to submit this PR against branch 6.3, right?
Im also not sure about the CHANGELOG.md entry I should make. Would I add this under the 6.3.1 section or where?