8000 [Console] Add placeholders to ProgressBar for exact times by maxbeckers · Pull Request #50537 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console] Add placeholders to ProgressBar for exact times #50537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2023
Merged

[Console] Add placeholders to ProgressBar for exact times #50537

merged 1 commit into from
Oct 10, 2023

Conversation

maxbeckers
Copy link
Contributor
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #49927
License MIT
Doc PR symfony/symfony-docs#... TBD

This is an idea for exact times using ProgressBar based on the idea of @GromNaN in the issue #49927.

Open to discuss this first way of implementing it.

I'll create the docs PR when the feature is agreed and there won't come up any bigger changes.

The Idea is to show the exact time in seconds, the ProgressBar will run / is running.

@maxbeckers maxbeckers requested a review from chalasr as a code owner June 2, 2023 11:44
@carsonbot carsonbot added this to the 6.4 milestone Jun 2, 2023
@maxbeckers maxbeckers force-pushed the patch_49927_console_remaining_time branch 3 times, most recently from 1eecd3b to 82a1c62 Compare June 5, 2023 05:09
@wouterj
Copy link
Member
wouterj commented Oct 8, 2023

I think we can simplify this to just replace the existing elapsed parameter with the new format. We do not promise backwards compatible CLI output, and I would argue that interactive elements like the progress bar should never be interpreted by any program anyways.

@maxbeckers maxbeckers force-pushed the patch_49927_console_remaining_time branch from 82a1c62 to c0ca8f9 Compare October 9, 2023 09:02
@maxbeckers
Copy link
Contributor Author

Thanks @wouterj and @OskarStark for your input. I now changed it.

@OskarStark OskarStark added the ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" label Oct 9, 2023
wouterj
wouterj approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@maxbeckers maxbeckers force-pushed the patch_49927_console_remaining_time branch from c0ca8f9 to 190f835 Compare October 9, 2023 09:51
@maxbeckers maxbeckers force-pushed the patch_49927_console_remaining_time branch from 190f835 to b553dd9 Compare October 9, 2023 11:19
@OskarStark OskarStark changed the title [Console] Add Placeholders to ProgressBar for exactly times [Console] Add placeholders to ProgressBar for exact times Oct 9, 2023
@fabpot
Copy link
Member
fabpot commented Oct 10, 2023

Thank you @maxbeckers.

@fabpot fabpot mentioned this pull request Oct 10, 2023
Closed
@fabpot fabpot merged commit 3ceb506 into symfony:6.4 Oct 10, 2023
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@GromNaN GromNaN GromNaN approved these changes

@wouterj wouterj wouterj approved these changes

@OskarStark OskarStark OskarStark approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Feature ❄️ Feature Freeze Important Pull Requests to finish before the next Symfony "feature freeze" Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Console] Improve the helpfulness of %remaining% in Progress Bar
6 participants
@maxbeckers @wouterj @fabpot @GromNaN @OskarStark @carsonbot
0