[Notifier] Document Notifier options in README files #50349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
commented
May 16, 2023
OskarStark
reviewed
May 17, 2023
OskarStark
reviewed
May 17, 2023
OskarStark
reviewed
May 17, 2023
OskarStark
reviewed
May 17, 2023
OskarStark
reviewed
May 17, 2023
nicolas-grekas
previously approved these changes
May 18, 2023
| $sms = new SmsMessage('+1411111111', 'My message'); | ||
|
|
||
| $options = (new ContactEveryoneOptions()) | ||
| ->diffusionName('My label') |
There was a problem hiding this comment.
the method should be changed to accept a string also (would be consistent with the constructor of the transport)
@franckranaivo where can I find the doc that tells about this parameter?
There was a problem hiding this comment.
Sorry, for the late answer. I picked these parameters (including diffusionName) from their manuals. But yes it should accept string. Here is the manual, idk if there is an english version.
https://ceo-be.multimediabs.com/attachments/hosted/lightApiManualsFR
They start to talk about these on page 9.
Apparently, it is useful for categorizing sms logs.
OskarStark
approved these changes
May 18, 2023
0e0dcbf to
6153f04
Compare
|
Thank you @alamirault. |
This was referenced May 20, 2023
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2023
…amirault) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Notifier] Document Notifier options in README files | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continue #50349 on 6.3 branch Commits ------- e770344 [Notifier] Document Notifier options in README files
nicolas-grekas
added a commit
that referenced
this pull request
May 22, 2023
… (alamirault) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Notifier] Document Notifier options in README files 5.4 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Continue #50349 on 5.4 branch Commits ------- b670273 [Notifier] Document Notifier options in README files 5.4
Merged
nicolas-grekas
added a commit
that referenced
this pull request
May 30, 2023
This PR was merged into the 6.3 branch. Discussion ---------- [Notifier] Fix ContactEveryoneOptions | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Thanks to `@franckranaivo` in #50349 (comment) Commits ------- 8dd9d93 [Notifier] Fix ContactEveryoneOptions
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add missing
*Optionsdocumentations in notifier bridges readmeDocumented bridges are:
Waiting your feedback 😄
I will create another PR for AmazonSnsOptions, BandwidthOptions, ClickSendOptions, MobytOptions, PlivoOptions, RingCentralOptions, SmsmodeOptions, TwilioOptions after this one