8000 [Serializer] GetSetMethodNormalizer::supportss should not check ignored methods by nikophil · Pull Request #49720 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] GetSetMethodNormalizer::supportss should not check ignored methods #49720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Serializer] GetSetMethodNormalizer::supportss should not check ignored methods #49720

merged 1 commit into from
Mar 17, 2023

Conversation

nikophil
Copy link
Contributor
@nikophil nikophil commented Mar 17, 2023 •
edited by nicolas-grekas
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

GetSetMethodNormalizer support methods do not check if potentiel getters have #[Ignore] attribute

@nikophil nikophil requested a review from dunglas as a code owner March 17, 2023 13:50
@carsonbot carsonbot added this to the 6.2 milestone Mar 17, 2023
@nikophil nikophil force-pushed the fix/get-set-method-ignore branch from ffd763e to 858c233 Compare March 17, 2023 13:53
@nicolas-grekas nicolas-grekas modified the milestones: 6.2, 5.4 Mar 17, 2023
@nicolas-grekas nicolas-grekas changed the base branch from 6.2 to 5.4 March 17, 2023 15:02
@nicolas-grekas nicolas-grekas force-pushed the fix/get-set-method-ignore branch from 858c233 to 3ca371b Compare March 17, 2023 15:02
@nikophil
Copy link
Contributor Author

@nicolas-grekas I saw you've just rebased the PR on 5.4, but shouldn't it be compatible with php 7? thus $method->getAttributes() won't exist?

@nicolas-grekas nicolas-grekas force-pushed the fix/get-set-method-ignore branch from 3ca371b to 8296177 Compare March 17, 2023 15:14
@nicolas-grekas
Copy link
Member

Indeed, updated.

@nicolas-grekas
Copy link
Member

Thank you @nikophil.

@nicolas-grekas nicolas-grekas merged commit 7dccccd into symfony:5.4 Mar 17, 2023
This was referenced Mar 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nikophil @nicolas-grekas @carsonbot
0