10000 [Mailer] Fix error message in case of an SMTP error by fabpot · Pull Request #47162 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Fix error message in case of an SMTP error #47162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2022
Merged

[Mailer] Fix error message in case of an SMTP error #47162

merged 1 commit into from
Aug 3, 2022

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Aug 2, 2022
Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets n/a
License MIT
Doc PR n/a

@carsonbot carsonbot added this to the 6.1 milestone Aug 2, 2022
@alexislefebvre
Copy link
Contributor

Minor typo: it is written STMP instead of SMTP in the commit and title.

xabbuh
xabbuh reviewed Aug 2, 2022
View reviewed changes
src/Symfony/Component/Mailer/Transport/Smtp/EsmtpTransport.php
} catch (TransportExceptionInterface) {
return parent::executeCommand(sprintf("HELO %s\r\n", $this->getLocalDomain()), [250]);
}
$response = $this->executeCommand(sprintf("EHLO %s\r\n", $this->getLocalDomain()), [250]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we no longer need to catch transport exceptions anymore here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we know that EHLO is supported, so there is no need to fall back to HELO.

@fabpot fabpot changed the title [Mailer] Fix error message in case of an STMP error [Mailer] Fix error message in case of an SMTP error Aug 3, 2022
@fabpot fabpot force-pushed the mailer-bette-error-message-61 branch from da8afdc to 6a88663 Compare August 3, 2022 05:16
@fabpot fabpot merged commit f3a4818 into symfony:6.1 Aug 3, 2022
@fabpot fabpot deleted the mailer-bette-error-message-61 branch August 3, 2022 05:16
@fabpot fabpot mentioned this pull request Aug 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

Assignees
No one assigned
Labels
Bug Mailer Status: Needs Review
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@fabpot @alexislefebvre @xabbuh @carsonbot
0