8000 [Mailer] Add Infobip bridge by B-Galati · Pull Request #46211 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Add Infobip bridge #46211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

[Mailer] Add Infobip bridge #46211

merged 1 commit into from
Jul 20, 2022

Conversation

B-Galati
Copy link
Contributor
@B-Galati B-Galati commented Apr 29, 2022 •
edited by OskarStark
Loading
Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#16760

Hello,

Add Infobip as new email provider for Symfony Mailer!

Co-authored with @jbdelhommeau 👍

@carsonbot carsonbot added this to the 6.1 milestone Apr 29, 2022
@B-Galati B-Galati mentioned this pull request Apr 29, 2022
Merged
OskarStark
OskarStark reviewed Apr 29, 2022
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, thank you

@B-Galati
Copy link
Contributor Author

@OskarStark Thanks! All fixed, hope I did not forget anything 👍

@B-Galati B-Galati force-pushed the infobip-mailer branch 2 times, most recently from b7df661 to 87d660c Compare May 2, 2022 09:28
@B-Galati
Copy link
Contributor Author
B-Galati commented May 2, 2022

just done a little update to fix the SMTP client, all good now.

@B-Galati
Copy link
Contributor Author
B-Galati commented May 2, 2022

Rebased with last commit to check if it fixes psalm error.

@fabpot fabpot modified the milestones: 6.1, 6.2 May 8, 2022
@B-Galati
Copy link
Contributor Author
B-Galati commented May 9, 2022

@OskarStark I know it's a bit late but do you know if it could be released with 6.1?

@fabpot
Copy link
Member
fabpot commented May 9, 2022

We’ve been in feature freeze for more than a month now, so it’ll be for 6.2 unfortunately.

@B-Galati
Copy link
Contributor Author

Thank you, I will change the branch target then 👍

@OskarStark OskarStark requested a review from fabpot June 1, 2022 12:24
@OskarStark OskarStark mentioned this pull request Jun 1, 2022
Merged
fabpot added a commit that referenced this pull request Jun 2, 2022
@fabpot
minor #46542 [Mailer] Sort transports alphabetically (OskarStark)
18aea63 
This PR was merged into the 5.4 branch.

Discussion
----------

[Mailer] Sort transports alphabetically

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Spotted in #46211
| License       | MIT
| Doc PR        | -

So the sorting does not needs to be done in #46211

cc @B-Galati

Commits
-------

5d76dbb [Mailer] Sort transports alphabetically
@fabpot
Copy link
Member
fabpot commented Jul 17, 2022

@B-Galati Are you still interested in finishing this PR?

@B-Galati
Copy link
Contributor Author

Yes @fabpot 👍

@B-Galati @jbdelhommeau
[Mailer] Add Infobip bridge
1f9c282 
Co-Authored-By: Jean-Baptiste Delhommeau <jeanbadel@gmail.com>
Co-Authored-By: Benoit Galati <benoit.galati@gmail.com>
@B-Galati
Copy link
Contributor Author

@fabpot it's ready, the CI fa 8000 ilure looks unrelated but I am may be wrong of course.

@fabpot
Copy link
Member
fabpot commented Jul 20, 2022

@B-Galati Can you create a PR on symfony/recipes?

@fabpot
Copy link
Member
fabpot commented Jul 20, 2022

Thank you @B-Galati.

@fabpot fabpot merged commit c5aeafe into symfony:6.2 Jul 20, 2022
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Jul 23, 2022
@javiereguiluz
minor symfony#16760 [Mailer] Add Infobip bridge (B-Galati)
e03b442 
This PR was merged into the 6.2 branch.

Discussion
----------

[Mailer] Add Infobip bridge

Hello,

Companion for symfony/symfony#46211!

Commits
-------

f14ec5d [Mailer] Add Infobip bridge
@B-Galati B-Galati deleted the infobip-mailer branch July 26, 2022 09:07
@B-Galati
Copy link
Contributor Author

PR for the recipe opened symfony/recipes#1113 ✔️

@xabbuh xabbuh mentioned this pull request Jul 29, 2022
Merged
fabpot added a commit that referenced this pull request Jul 29, 2022
@fabpot
minor #47106 [Mailer] re-add test (xabbuh)
4811813 
This PR was merged into the 6.2 branch.

Discussion
----------

[Mailer] re-add test

| Q             | A
| ------------- | ---
| Branch?       | 6.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

This test was initially added in #46211 but failed because of the changes from #46963 that were merged in the meantime. The test was then removed in e54dd38. This is a fixed version that is passing again.

Commits
-------

1026e16 re-add test
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@B-Galati @fabpot @OskarStark @carsonbot
0