10000 [FrameworkBundle] Deprecate the messenger.reset_on_message config option by upyx · Pull Request #45705 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Deprecate the messenger.reset_on_message config option #45705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2022
Merged

[FrameworkBundle] Deprecate the messenger.reset_on_message config option #45705

merged 1 commit into from
Mar 24, 2022

Conversation

upyx
Copy link
Contributor
@upyx upyx commented Mar 10, 2022
Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? yes
Tickets Continues #43203 (comment)
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot carsonbot added this to the 6.1 milestone Mar 10, 2022
chalasr
chalasr reviewed Mar 18, 2022
View reviewed changes
UPGRADE-6.1.md Outdated
FrameworkBundle
---------------

* Deprecate the `reset_on_message` config option. It can be set to `true` only and does nothing now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention the alternative?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the alternative? The reset_on_message does nothing already. It was nedded to indicate the changing of the default behaviour in 6.0.

The original plan: #43133 (comment)
Future details: #43203 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add the info: "To prevent services resetting after each message you can set the "--no-reset" option in "messenger:consume" command?"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me @upyx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chalasr @fabpot
Done

GromNaN
GromNaN approved these changes Mar 21, 2022
View reviewed changes
Copy link
Member
@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new way is already described in the error message.

The "framework.messenger.reset_on_message" configuration option can be set to "true" only. To prevent services resetting after each message you can set the "--no-reset" option in "messenger:consume" command.'

@upyx upyx force-pushed the deprecate-reset-on-message branch from 2f091e5 to ba842e3 Compare March 24, 2022 11:54
@chalasr chalasr force-pushed the deprecate-reset-on-message branch from ba842e3 to 6591c8f Compare March 24, 2022 11:58
@chalasr
Copy link
Member
chalasr commented Mar 24, 2022

Thank you @upyx.

@chalasr chalasr merged commit 4fe223f into symfony:6.1 Mar 24, 2022
@chalasr chalasr mentioned this pull request Mar 24, 2022
Closed
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

@chalasr chalasr chalasr left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Deprecation FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
6 participants
@upyx @chalasr @fabpot @nicolas-grekas @GromNaN @carsonbot
0