8000 [SecurityBundle] Deprecate not configuring explicitly a provider for custom_authenticators when there is more than one registered provider by lyrixx · Pull Request #43835 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[SecurityBundle] Deprecate not configuring explicitly a provider for custom_authenticators when there is more than one registered provider #43835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2021
Merged

[SecurityBundle] Deprecate not configuring explicitly a provider for custom_authenticators when there is more than one registered provider #43835

merged 1 commit into from
Oct 30, 2021

Conversation

lyrixx
Copy link
Member
@lyrixx lyrixx commented Oct 29, 2021
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets
License MIT
Doc PR not needed I guess

@lyrixx
[SecurityBundle] Deprecate not configuring explicitly a provider for …
8000
a2c9a44 
…custom_authenticators when there is more than one registered provider
@carsonbot carsonbot added this to the 5.4 milestone Oct 29, 2021
fabpot
fabpot approved these changes Oct 30, 2021 •
edited
Loading
View reviewed changes
@fabpot
Copy link
Member
fabpot commented Oct 30, 2021

Thank you @lyrixx.

@fabpot fabpot mentioned this pull request Oct 30, 2021
Closed
@fabpot fabpot merged commit fcfcc32 into symfony:5.4 Oct 30, 2021
@lyrixx lyrixx deleted the secur-default-user-provider branch October 30, 2021 15:03
@derrabus
Copy link
Member

This deprecation is apparently causing our CI to fail on 5.4 because it's triggered in a SecurityBundle test:

https://github.com/symfony/symfony/runs/4055121217?check_suite_focus=true#step:8:853

Can you take a look, @lyrixx?

@chalasr chalasr mentioned this pull request Oct 30, 2021
Merged
fabpot added a commit that referenced this pull request Oct 31, 2021
@fabpot
minor #43841 [SecurityBundle] Fix tests (chalasr)
984cd83 
This PR was merged into the 5.4 branch.

Discussion
----------

[SecurityBundle] Fix tests

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | -
| New feature?  | -
| Deprecations? | -
| Tickets       | -
| License       | MIT
| Doc PR        | -

We missed flagging this test as legacy in #43835.

Commits
-------

69f12ef [SecurityBundle] Fix tests
This was referenced Nov 5, 2021
Merged
Merged
@chalasr chalasr mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Deprecation SecurityBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@lyrixx @fabpot @derrabus @carsonbot
0