[Validator] Update MIR card scheme #42341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Aug 1, 2021
src/Symfony/Component/Validator/Constraints/CardSchemeValidator.php
Outdated
Show resolved
Hide resolved
|
Do you have a piece of documentation at hand for this card format? I cannot really tell if your change is correct. |
ec548d5 to
fb15542
Compare
|
We are working with MIR card 19 digits length but I didn't find any documentation for it except https://en.wikipedia.org/wiki/Payment_card_number which already been used as trusted source |
derrabus
approved these changes
Aug 1, 2021
OskarStark
approved these changes
Aug 1, 2021
|
Thanks for fixing this bug @ossinkine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update card scheme validator for MIR cards, it's allowing 16-19 numbers length