10000 [Routing] Remove deprecation layer by derrabus · Pull Request #41371 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Routing] Remove deprecation layer #41371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2021
Merged

[Routing] Remove deprecation layer #41371

merged 1 commit into from
May 27, 2021

Conversation

derrabus
Copy link
Member
Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.0 milestone May 21, 2021
@derrabus derrabus force-pushed the remove/routing-deprecations branch from 51927aa to 0a135a5 Compare May 21, 2021 19:51
@carsonbot
Copy link

Hey!

I think @fancyweb has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@derrabus derrabus force-pushed the remove/routing-deprecations branch from 0a135a5 to 930a78f Compare May 22, 2021 20:00
@nicolas-grekas nicolas-grekas mentioned this pull request May 23, 2021
Closed
nicolas-grekas
nicolas-grekas reviewed May 23, 2021
View reviewed changes
src/Symfony/Component/Routing/Annotation/Route.php
{
$this->schemes = \is_array($schemes) ? $schemes : [$schemes];
$this->schemes = (array) $schemes;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for a lower branch?

@derrabus derrabus force-pushed the remove/routing-deprecations branch from 930a78f to 1e9cfe4 Compare May 24, 2021 12:49
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 1cdd48d into symfony:6.0 May 27, 2021
@derrabus derrabus deleted the remove/routing-deprecations branch May 27, 2021 15:44
@fabpot fabpot mentioned this pull request Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Routing Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@derrabus @carsonbot @nicolas-grekas
0