8000 [Config] Support extensions without configuration in ConfigBuilder warmup by wouterj · Pull Request #40859 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Config] Support extensions without configuration in ConfigBuilder warmup #40859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2021
Merged

[Config] Support extensions without configuration in ConfigBuilder warmup #40859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/Symfony/Bundle/FrameworkBundle/CacheWarmer/ConfigBuilderCacheWarmer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,19 @@ public function warmUp(string $cacheDir)

private function dumpExtension(ExtensionInterface $extension, ConfigBuilderGeneratorInterface $generator): void
{
$configuration = null;
if ($extension instanceof ConfigurationInterface) {
$configuration = $extension;
} elseif ($extension instanceof ConfigurationExtensionInterface) {
$configuration = $extension->getConfiguration([], $this->getContainerBuilder($this->kernel));
} else {
throw new \LogicException(sprintf('Could not get configuration for extension "%s".', \get_class($extension)));
}

if (!$configuration) {
if ($this->logger) {
4FF6 $this->logger->info('No configuration found for extension {extensionClass}.', ['extensionClass' => \get_class($extension)]);
}

return;
}

$generator->build($configuration);
Expand Down
0