8000 [Form] error if the input string couldn't be parsed as a date by xabbuh · Pull Request #40598 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] error if the input string couldn't be parsed as a date #40598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2021
Merged

[Form] error if the input string couldn't be parsed as a date #40598

merged 1 commit into from
Mar 28, 2021

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Mar 27, 2021
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40597
License MIT
Doc PR

When the Intl polyfill is used instead of the PHP intl extension, the
intl_get_error_code() function always returns 0 no matter if the input
string could be parsed.

@xabbuh
error if the input string couldn't be parsed as a date
8000
5ce5300 
When the Intl polyfill is used instead of the PHP intl extension, the
intl_get_error_code() function always returns 0 no matter if the input
string could be parsed.
@xabbuh xabbuh added this to the 4.4 milestone Mar 27, 2021
@xabbuh xabbuh requested a review from yceruto as a code owner March 27, 2021 17:08
@xabbuh xabbuh mentioned this pull request Mar 27, 2021
Closed
@nicolas-grekas
Copy link
Member

Would there be a way to improve the polyfill in this regard?

kamil-jakubowski
kamil-jakubowski approved these changes Mar 27, 2021
View reviewed changes
Copy link
@kamil-jakubowski kamil-jakubowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That workaround works when using Symfony Intl Polyfill (with intl ext uninstalled) on Symfony 5.2
image

Although, there is a bug still in Symfony Intl Polyfill :)

@fabpot
Copy link
Member
fabpot commented Mar 28, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit 5666a45 into symfony:4.4 Mar 28, 2021
@xabbuh xabbuh deleted the issue-40597 branch March 28, 2021 07:47
This was referenced Mar 29, 2021
Merged
Merged
@xabbuh
Copy link
Member Author
xabbuh commented Apr 9, 2021

@kamil-jakubowski I was looking into fixing the Intl polyfill package, but I actually couldn't reproduce the behaviour that you experienced. Which exact version of the polyfill package do you use? Can you debug why the error code isn't stored correctly?

@emilylark

This comment was marked as spam.

Sign in to view
@symfony symfony deleted a comment from emilylark May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@kamil-jakubowski kamil-jakubowski kamil-jakubowski approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @nicolas-grekas @fabpot @emilylark @OskarStark @kamil-jakubowski @carsonbot
0