[Component][Finder] tests and condition: contains() used on dir #4056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,7 +30,15 @@ public function accept() | |||
| return true; | |||
| } | |||
|
|
|||
| $content = file_get_contents($this->getRealpath()); | |||
| if ($this->isDir()) { | |||
| throw new \RuntimeException(sprintf('contains() can not be called on directory "%s".', $this->getRealpath())); | |||
There was a problem hiding this comment.
you should not throw an exception IMO as the user cannot avoid calling it on a dir as soon as the folder in which it searches for files has subfolders.
There was a problem hiding this comment.
well, if the folder matches other filters of course
There was a problem hiding this comment.
If you call files() then all directories are excluded and no exception is thrown. IMHO the question is: what should be done when user calls:
$finder->in('some/dir')->contains('abc');
Following your suggestion I return false.
fabpot
added a commit
that referenced
this pull request
May 11, 2012
Commits ------- f2fea97 [Component][Finder] tests and condition: contains() used on dir Discussion ---------- [Component][Finder] tests and condition: contains() used on dir Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: - Todo: - `Finder::contains()` and `Finder::notContains()` can't be used on directories. --------------------------------------------------------------------------- by travisbot at 2012-05-08T06:33:11Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1273818) (merged f2fea97 into 919604a).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
Finder::contains()andFinder::notContains()can't be used on directories.