8000 [Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer by Warxcell · Pull Request #40510 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer #40510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2021
Merged

[Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer #40510

merged 1 commit into from
Mar 26, 2021

Conversation

Warxcell
Copy link
Contributor

Fixes #40456

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40456
License MIT

@Warxcell Warxcell requested review from xabbuh and yceruto as code owners March 18, 2021 13:29
@carsonbot carsonbot added this to the 4.4 milestone Mar 18, 2021
@Warxcell Warxcell force-pushed the fixes_40456 branch 2 times, most recently from 884f74f to bafdf4b Compare March 18, 2021 13:37
@Warxcell Warxcell changed the title IntegerType: Always use en for IntegerToLocalizedStringTransformer [Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer Mar 18, 2021
derrabus
derrabus requested changes Mar 18, 2021
View reviewed changes
Copy link
Member
@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Can you please add a test for your changes?

@carsonbot carsonbot changed the title [Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer IntegerType: Always use en for IntegerToLocalizedStringTransformer Mar 18, 2021
@Warxcell
Copy link
Contributor Author
Warxcell commented Mar 18, 2021 •
edited
Loading

Thank you for your contribution. Can you please add a test for your changes?

Where are tests for this FormType and Transformer? I don't see them.

Nvm, found them.

@Warxcell Warxcell force-pushed the fixes_40456 branch 3 times, most recently from b413f1b to 68ad1bc Compare March 18, 2021 15:27
@Warxcell Warxcell requested a review from derrabus March 18, 2021 15:28
@xabbuh xabbuh added the Form label Mar 18, 2021
@carsonbot carsonbot changed the title IntegerType: Always use en for IntegerToLocalizedStringTransformer [Form] IntegerType: Always use en for IntegerToLocalizedStringTransformer Mar 18, 2021
@Warxcell Warxcell force-pushed the fixes_40456 branch 2 times, most recently from 957265a to 382fbb4 Compare March 18, 2021 15:40
xabbuh
xabbuh reviewed Mar 26, 2021
View reviewed changes
@Warxcell Warxcell requested a review from xabbuh March 26, 2021 09:02
xabbuh
xabbuh reviewed Mar 26, 2021
View reviewed changes
@xabbuh
Copy link
Member
xabbuh commented Mar 26, 2021

Thank you @Warxcell.

@xabbuh xabbuh merged commit d0875a9 into symfony:4.4 Mar 26, 2021
@Warxcell Warxcell deleted the fixes_40456 branch March 26, 2021 14:53
This was referenced Mar 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto yceruto approved these changes

@derrabus derrabus Awaiting requested review from derrabus

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Warxcell @xabbuh @derrabus @yceruto @carsonbot
0