[Inflector][String] Fixed pluralize "coupon" #40499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue needs to be fixed on 4.4 (inflector component). |
|
You are correct. The bug existed in 4.4 in the inflector component too. I guess it will be merged up properly if I target 4.4. The PR is updated. |
javiereguiluz
approved these changes
Mar 17, 2021
| @@ -231,6 +231,9 @@ final class Inflector | |||
| // bacteria (bacterium), criteria (criterion), phenomena (phenomenon) | |||
| ['noi', 3, true, true, 'ions'], | |||
|
|
|||
| // coupon (coupons) | |||
| ['nopuoc', 6, true, true, 'coupons'], | |||
There was a problem hiding this comment.
maybe we can widen this to
['nop', 3, true, true, 'pons'],
There was a problem hiding this comment.
I confirm we should do this, see https://en.wiktionary.org/wiki/Category:English_plurals_ending_in_%22-a%22: it lists no English words that end with pon and have a pa plural.
derrabus
approved these changes
Mar 17, 2021
8000
|
Thank you @Nyholm. |
|
Thank you for merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rule for "bacteria (bacterium), criteria (criterion), phenomena (phenomenon)" is producing this behaviour. I added an exception to the "criterion exception".
"coupon" is an old French word, that is maybe why it does not follow the classic "on" rule... I dont know. The test passes and I dont think I've added any side-effects.
This is also my first time working with the
EnglishInflector.