8000 [TwigBridge] Fix "Serialization of 'Closure'" error when rendering an TemplatedEmail by jderusse · Pull Request #40446 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Fix "Serialization of 'Closure'" error when rendering an TemplatedEmail #40446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2021
Merged

[TwigBridge] Fix "Serialization of 'Closure'" error when rendering an TemplatedEmail #40446

merged 1 commit into from
Mar 11, 2021

Conversation

jderusse
Copy link
Member
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40445
License MIT
Doc PR

When context contains a closure, it can't be serialized. In that case, we now assume that fingerprint is always different, and in that case, email will always be re-rendered

@carsonbot carsonbot added this to the 4.4 milestone Mar 11, 2021
nicolas-grekas
nicolas-grekas reviewed Mar 11, 2021
View reviewed changes
@stof
Copy link
Member
stof commented Mar 11, 2021

The title of the PR should clearly be updated, to have a proper message in changelogs

@jderusse jderusse changed the title Twig render Fix "Serialization of 'Closure'" error when rendering an TemplatedEmail Mar 11, 2021
@carsonbot carsonbot changed the title Fix "Serialization of 'Closure'" error when rendering an TemplatedEmail [TwigBridge] Fix "Serialization of 'Closure'" error when rendering an TemplatedEmail Mar 11, 2021
@fabpot
Copy link
Member
fabpot commented Mar 11, 2021

Thank you @jderusse.

@fabpot fabpot merged commit 9f3c30a into symfony:4.4 Mar 11, 2021
@PhilETaylor
Copy link
Contributor

Thank you @jderusse hope the report helped identify the issue easy enough for you.

@jderusse jderusse deleted the twig-render branch March 11, 2021 16:25
This was referenced Mar 29, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed TwigBridge
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
7 participants
@jderusse @stof @fabpot @PhilETaylor @nicolas-grekas @derrabus @carsonbot
0