[HttpClient] throw clearer error when no scheme is provided #39286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me. Let's see what @nicolas-grekas thinks about this. |
derrabus
reviewed
Dec 2, 2020
derrabus
approved these changes
Dec 2, 2020
jderusse
approved these changes
Dec 4, 2020
fabpot
approved these changes
Dec 5, 2020
|
Thank you @BackEndTea. |
47c7c63 to
4d821d6
Compare
|
Thank you @derrabus , @nicolas-grekas & @fabpot |
This was referenced Dec 18, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be considred a BC break, as previously this would've a
TransportExcepiton, instead of anInvalidArgumentException. But i see no reason to catch this specific error, as it would generally be a configuration error.