8000 [RateLimiter] Make sure we actually can use sliding_window and no_limit by Nyholm · Pull Request #38674 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[RateLimiter] Make sure we actually can use sliding_window and no_limit #38674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2020
Merged

[RateLimiter] Make sure we actually can use sliding_window and no_limit #38674

merged 1 commit into from
Oct 22, 2020

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Oct 22, 2020 •
edited
Loading
Q A
Branch? 5.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

I found that we never tested the config on the actually RateLimiter class. This PR adds a tests and bugfix

@wouterj
Copy link
Member
wouterj commented Oct 22, 2020

Thanks for adding so many nice fixes to the component, Tobias!

@wouterj wouterj merged commit e1825e0 into symfony:5.x Oct 22, 2020
@Nyholm
Copy link
Member Author
Nyholm commented Oct 22, 2020

Im happy you like them.

Thank you for merging.

@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jderusse jderusse jderusse approved these changes

@wouterj wouterj wouterj approved these changes

Assignees
No one assigned
Labels
Bug RateLimiter Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @wouterj @jderusse @carsonbot
0