[Mime] Fix serialization of RawMessage #38433
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbertsoft
commented
Oct 6, 2020
|
|
||
| $message = new RawMessage(new \ArrayObject(['some', ' ', 'string'])); | ||
| $message = new RawMessage($message->toIterable()); | ||
| $this->assertEquals('some string', unserialize(serialize($message))->toString()); |
There was a problem hiding this comment.
This line will throw Exception: Serialization of 'Generator' is not allowed without the fix above
fabpot
approved these changes
Oct 6, 2020
|
Thank you @gilbertsoft. |
fabpot
added a commit
that referenced
this pull request
Oct 6, 2020
This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [Mime] Fix serialization of RawMessage | Q | A | ------------- | --- | Branch? | 4.4 <!-- see below --> | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #38430, Related #33394 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | - <!-- required for new features --> The serialization of RawMessage is currently broken if using a generator for message like done by `Symfony\Component\Mailer\SentMessage` see https://github.com/symfony/symfony/blob/5f1c3a797247a6d54992384df00bb22741fc1c34/src/Symfony/Component/Mailer/SentMessage.php#L45 This patch converts the message to a string so further serialization can be done. This patch probably also solves #33394. <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. --> Commits ------- fd99eb2 [Mime] Fix serialization of RawMessage
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialization of RawMessage is currently broken if using a generator for message like done by
Symfony\Component\Mailer\SentMessageseesymfony/src/Symfony/Component/Mailer/SentMessage.php
Line 45 in 5f1c3a7
This patch converts the message to a string so further serialization can be done.
This patch probably also solves #33394.