8000 [Yaml] Fix for #36624; Allow PHP constant as first key in block by jnye · Pull Request #37744 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Yaml] Fix for #36624; Allow PHP constant as first key in block #37744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

[Yaml] Fix for #36624; Allow PHP constant as first key in block #37744

merged 1 commit into from
Aug 11, 2020

Conversation

jnye
Copy link
Contributor
@jnye jnye commented Aug 5, 2020
Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36624
License MIT
Doc PR

When using a PHP constant in the first key of a mapping the parser would throw an exception. However if you used a PHP constant in any other key but the first it was allowed. This fix allows PHP constant as the first key.

I've included a test for this parser error along with the fix.

@jnye jnye requested a review from xabbuh as a code owner August 5, 2020 21:03
xabbuh
xabbuh reviewed Aug 7, 2020
View reviewed changes
xabbuh
xabbuh reviewed Aug 7, 2020
View reviewed changes
xabbuh
xabbuh reviewed Aug 7, 2020
View reviewed changes
Copy link
Member
@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could expand the test to check for more tags using a data provider.

xabbuh
xabbuh reviewed Aug 8, 2020
View reviewed changes
@xabbuh xabbuh added this to the 3.4 milestone Aug 10, 2020
@fabpot
Copy link
Member
fabpot commented Aug 11, 2020

Thank you @jnye.

@fabpot fabpot merged commit a77901d into symfony:3.4 Aug 11, 2020
This was referenced Aug 31, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jnye @fabpot @xabbuh @carsonbot
0