8000 Silence stream_isatty and posix_isatty by ostrolucky · Pull Request #37122 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Silence stream_isatty and posix_isatty #37122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Silence stream_isatty and posix_isatty #37122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Symfony/Component/Console/Helper/QuestionHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,11 +512,11 @@ private function isTty(): bool
$inputStream = !$this->inputStream && \defined('STDIN') ? STDIN : $this->inputStream;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just discovered that this is enough to fix the warning:
$inputStream = null === $this->inputStream || (\defined('STDIN') && STDIN === $this->inputStream) ? fopen('php://input', 'r') : $this->inputStream;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this trades one error for another. This DOES fix the "bytes of buffered data lost during stream conversion" error. But now, as soon as an answer fails validation, instead of asking again, it ALWAYS fails immediately - it falls out of the loop and hits the throw at the end

symfony/src/Symfony/Component/Console/Helper/QuestionHelper.php

Line 479 in 5a74790

throw $error;

Here is a SUPER simple reproduced - https://github.com/weaverryan/console-question-reproducer - I tried the current code on that and your proposed patch. But this PR doesn't fix the issue either - I think this PR sort of fixes it, but then I think we're still hitting #37046.

The only thing that fully works is reverting back to 5.0.8 - you can try all of this pretty quickly with the reproducer.


if (\function_exists('stream_isatty')) {
return stream_isatty($inputStream);
return @stream_isatty($inputStream);
}

if (\function_exists('posix_isatty')) {
return posix_isatty($inputStream);
return @posix_isatty($inputStream);
}

return true;
Expand Down
0