8000 ✨ [Mailer] Add Mailjet bridge by tcheymol · Pull Request #36541 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

✨ [Mailer] Add Mailjet bridge #36541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2020
Merged

✨ [Mailer] Add Mailjet bridge #36541

merged 1 commit into from
Aug 18, 2020

Conversation

tcheymol
Copy link
Contributor
@tcheymol tcheymol commented Apr 23, 2020 •
edited
Loading
Q A
Branch? master
Bug fix? no
New feature? yes
Deprecations? no
Tickets no
License MIT
Doc PR symfony/symfony-docs#14095

@chalasr chalasr added this to the next milestone Apr 23, 2020
@tcheymol 8000 tcheymol force-pushed the mailer/add-mailjet branch 2 times, most recently from cc30b0c to b881f9b Compare April 23, 2020 09:13
@tcheymol tcheymol force-pushed the mailer/add-mailjet branch 2 times, most recently from 565a9ae to bc1685e Compare April 23, 2020 19:22
@lwillems
Copy link

@tcheymol what about Api transport with mailjet ? i was working on it before i saw your PR so perhaps i can help if you have not done already ?

@tcheymol
Copy link
Contributor Author

@lwillems Yes, I started working on it, but I needed a first working version quite quick, so, I did not work on the Api part at first

@tcheymol tcheymol force-pushed the mailer/add-mailjet branch 2 times, most recently from ea96e6f to ccf7e8a Compare April 24, 2020 19:24
@tcheymol tcheymol force-pushed the mailer/add-mailjet branch from ccf7e8a to 00d0b38 Compare July 25, 2020 13:00
@fabpot
Copy link
Member
fabpot commented Aug 6, 2020

@tcheymol Any plan to add support for the Mailjet API? Perhaps @lwillems can help you finish the PR?

@tcheymol
Copy link
Contributor Author
tcheymol commented Aug 6, 2020

@fabpot Yes, that is my plan indeed :)

@fabpot
Copy link
Member
fabpot commented Aug 10, 2020

@tcheymol Can you submit a PR on symfony/recipes (you can have a look at other notifier bridge recipes to get some inspiration)?

@tcheymol
Copy link
Contributor Author

@fabpot You are right, I will look at the recipes, I will work on this this week

@tcheymol tcheymol force-pushed the mailer/add-mailjet branch from 00d0b38 to 51b3f67 Compare August 17, 2020 19:47
This was referenced Aug 17, 2020
Merged
Merged
@tcheymol tcheymol force-pushed the mailer/add-mailjet branch from b10612f to e4f54e3 Compare August 18, 2020 07:32
@tcheymol
Copy link
Contributor Author

@lwillems I have been working on API integration, if you want to help me with your experience, I would love it

fabpot
fabpot requested changes Aug 18, 2020
View reviewed changes
YaFou
YaFou suggested changes Aug 18, 2020
View reviewed changes
@tcheymol tcheymol force-pushed the mailer/add-mailjet branch 2 times, most recently from 87cd915 to c844dcb Compare August 18, 2020 08:15
@tcheymol tcheymol force-pushed the mailer/add-mailjet branch from c844dcb to 17b2439 Compare August 18, 2020 08:16
@tcheymol
Copy link
Contributor Author

@tcheymol Can you submit a PR on symfony/recipes (you can have a look at other notifier bridge recipes to get some inspiration)?

symfony/recipes#809

By the way, how do you handle Packagist repositories creation ?

@fabpot
Copy link
Member
fabpot commented Aug 18, 2020

@tcheymol Can you submit a PR on symfony/recipes (you can have a look at other notifier bridge recipes to get some inspiration)?

symfony/recipes#809

By the way, how do you handle Packagist repositories creation ?

Not sure I understand the question, but the code is automatically extracted to its own repository which is then submitted to Packagist.

fabpot
fabpot approved these changes Aug 18, 2020
View reviewed changes
src/Symfony/Component/Mailer/Bridge/Mailjet/README.md
Provides Mailjet integration for Symfony Mailer.



Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra blank lines can be removed

src/Symfony/Component/Mailer/Bridge/Mailjet/README.md


Configuration examples :
---------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed as it's not a title.

src/Symfony/Component/Mailer/Bridge/Mailjet/README.md
---------

```dotenv
# Api usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API

src/Symfony/Component/Mailer/Bridge/Mailjet/README.md
```dotenv
# Api usage
MAILER_DSN=mailjet+api://$PUBLIC_KEY:$PRIVATE_KEY@default
# Smtp usage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMTP

@fabpot
Copy link
Member
fabpot commented Aug 18, 2020

@tcheymol Can you fix the minor issues so that I can merge? Thank you.

@fabpot fabpot force-pushed the mailer/add-mailjet branch from 17b2439 to ee77fee Compare August 18, 2020 09:39
@fabpot
Copy link
Member
fabpot commented Aug 18, 2020

Thank you @tcheymol.

@fabpot fabpot merged commit 7974f2a into symfony:master Aug 18, 2020
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Aug 26, 2020
@OskarStark
feature #14095 [Mailer] Add documentation for Mailjet mailer (tcheymol)
322e003 
This PR was merged into the master branch.

Discussion
----------

[Mailer] Add documentation for Mailjet mailer

Documenting the introduction of the Mailjet mailer component ref: [symfony/symfony#36541 (comment)](symfony/symfony#36541)

Commits
-------

8586afa [Mailer] Add documentation for Mailjet mailer
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
@fabpot fabpot mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@YaFou YaFou YaFou requested changes

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
8 participants
@tcheymol @lwillems @fabpot @noniagriconomie @YaFou @nicolas-grekas @chalasr @carsonbot
0