[3.4][DoctrineBridge] Use new Types::* constants and support new json type #35817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Feb 21, 2020
|
I think fabbot failures should be ignored based on the existant code. |
fancyweb
commented
Feb 21, 2020
55baa60 to
eb6e219
Compare
fancyweb
commented
Feb 21, 2020
fancyweb
commented
Feb 21, 2020
fancyweb
commented
Feb 21, 2020
Taluu
8000
reviewed
Feb 22, 2020
Taluu
approved these changes
Feb 22, 2020
eb6e219 to
04649fd
Compare
04649fd to
3e35fa5
Compare
nicolas-grekas
approved these changes
Feb 24, 2020
|
Thank you @fancyweb. |
|
I failed to merge this in 4.4, please submit for 4.4 in #35819 or in a separate PR :) |
fabpot
added a commit
that referenced
this pull request
Feb 25, 2020
…rt new json types (fancyweb) This PR was merged into the 4.4 branch. Discussion ---------- [4.4][DoctrineBridge] Use new Types::* constants and support new json types | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | n 9403 o | Tickets | #35817 (comment) | License | MIT | Doc PR | - Commits ------- ddf3353 [4.4][DoctrineBridge] Use new Types::* constants and support new json type
This was referenced Feb 29, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
Type::*constants were moved and deprecated. This PR makes sure we use the good ones when they exist so we are prepared for their removal. It allows to be deprecation free. If deprecated constants could be detected, we would have failing tests 😄Also,
json_arraywas deprecated and renamed tojson, so I added support for this new type.Some new components also use these constants on upper branches, so I will submit PRs there.