8000 Fix Contracts autoloader typo by IonBazan · Pull Request #35610 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix Contracts autoloader typo #35610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2020
Merged

Fix Contracts autoloader typo #35610

merged 1 commit into from
Feb 6, 2020

Conversation

IonBazan
Copy link
Contributor
@IonBazan IonBazan commented Feb 6, 2020
Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #35526
License MIT

Autoloader does not include new Deprecation component when installing symfony/contracts due to typo.

Steps to reproduce:

composer dump-autoload -a
cat vendor/composer/autoload_files.php

Produces:

<?php

// autoload_files.php @generated by Composer

$vendorDir = dirname(dirname(__FILE__));
$baseDir = dirname($vendorDir);

return array(
    '0e6d7bf4a5811bfa5cf40c5ccd6fae6a' => $vendorDir . '/symfony/polyfill-mbstring/bootstrap.php',
    '25072dd6e2470089de65ae7bf11d3109' => $vendorDir . '/symfony/polyfill-php72/bootstrap.php',
    'f598d06aa772fa33d905e87be6398fb1' => $vendorDir . '/symfony/polyfill-intl-idn/bootstrap.php',
);

@nicolas-grekas nicolas-grekas added this to the next milestone Feb 6, 2020
@nicolas-grekas
Copy link
Member

Thank you @IonBazan.

nicolas-grekas added a commit that referenced this pull request Feb 6, 2020
@nicolas-grekas
minor #35610 Fix Contracts autoloader typo (IonBazan)
8a87490 
This PR was merged into the 5.1-dev branch.

Discussion
----------

Fix Contracts autoloader typo

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35526
| License       | MIT

Autoloader does not include new Deprecation component when installing `symfony/contracts` due to [typo](https://getcomposer.org/doc/04-schema.md#files).

Steps to reproduce:
```
composer dump-autoload -a
cat vendor/composer/autoload_files.php
```
Produces:
```
<?php

// autoload_files.php @generated by Composer

$vendorDir = dirname(dirname(__FILE__));
$baseDir = dirname($vendorDir);

return array(
    '0e6d7bf4a5811bfa5cf40c5ccd6fae6a' => $vendorDir . '/symfony/polyfill-mbstring/bootstrap.php',
    '25072dd6e2470089de65ae7bf11d3109' => $vendorDir . '/symfony/polyfill-php72/bootstrap.php',
    'f598d06aa772fa33d905e87be6398fb1' => $vendorDir . '/symfony/polyfill-intl-idn/bootstrap.php',
);
```

Commits
-------

d5bcaff Fix Contracts autoloader typo
@nicolas-grekas nicolas-grekas merged commit d5bcaff into symfony:master Feb 6, 2020
@IonBazan IonBazan deleted the patch-2 branch February 6, 2020 08:31
@nicolas-grekas nicolas-grekas modified the milestones: 6BA9 next, 5.1 May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@IonBazan @nicolas-grekas @carsonbot
0