10000 [FrameworkBundle][Cache] Don't deep-merge cache pools configuration by alxndrbauer · Pull Request #34577 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle][Cache] Don't deep-merge cache pools configuration #34577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2019
Merged

[FrameworkBundle][Cache] Don't deep-merge cache pools configuration #34577

merged 1 commit into from
Nov 25, 2019

Conversation

alxndrbauer
Copy link
Contributor
@alxndrbauer alxndrbauer commented Nov 24, 2019 •
edited by chalasr
Loading
Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #34488
License MIT

Prevents deep-merge of cache.pools.adapters configuration

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Nov 24, 2019
@alxndrbauer alxndrbauer force-pushed the ticket_34488_no-deep-merge branch from 2aece9f to 66cea79 Compare November 25, 2019 04:50
@alxndrbauer
Copy link
Contributor Author

Hmm sry didn't test it. Now one test is failing. I'll take a look later.

nicolas-grekas
nicolas-grekas approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure unrelated.

@fabpot fabpot force-pushed the ticket_34488_no-deep-merge branch from 66cea79 to a0d6d30 Compare November 25, 2019 07:15
@fabpot
Copy link
Member
fabpot commented Nov 25, 2019

Thank you @alxndrbauer.

fabpot added a commit that referenced this pull request Nov 25, 2019
@fabpot
bug #34577 [FrameworkBundle][Cache] Don't deep-merge cache pools conf…
350e110 
…iguration (alxndrbauer)

This PR was squashed before being merged into the 4.4 branch (closes #34577).

Discussion
----------

[FrameworkBundle][Cache] Don't deep-merge cache pools configuration

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #34488
| License       | MIT

Prevents deep-merge of cache.pools configuration

Commits
-------

a0d6d30 [FrameworkBundle][Cache] Don't deep-merge cache pools configuration
@fabpot fabpot merged commit a0d6d30 into symfony:4.4 Nov 25, 2019
@chalasr
Copy link
Member
chalasr commented Nov 25, 2019

This should have been merged into master I think, we used to merge similar changes as features.
If we consider this a bugfix, then it applies to 3.4 as well.

@nicolas-grekas
Copy link
Member

Supporting several adapters is a new feature of 4.4. Thus 4.4 :)

@chalasr
Copy link
Member
chalasr commented Nov 25, 2019

Indeed sorry , misled by the PR title which tells "pools"

@alxndrbauer alxndrbauer deleted the ticket_34488_no-deep-merge branch November 25, 2019 17:04
This was referenced Dec 1, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Cache FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@alxndrbauer @fabpot @chalasr @nicolas-grekas @carsonbot
0