[VarDumper] Add parameter type declarations #33153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #32179 |
| License | MIT |
| Doc PR | N/A |
57 tasks
16e1f9b to
74d5b63
Compare
azjezz
approved these changes
Aug 14, 2019
Tobion
reviewed
Aug 14, 2019
|
Some changes here are for 3.4, here you are: #33179 |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] fix annotations | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Found in #33153 Commits ------- 82f4766 [VarDumper] fix annotations
|
Thanks for the help, @nicolas-grekas. Can you please merge your changes upwards, so I can resolve the conflicts? |
166bb46 to
e9b9035
Compare
|
Looks like Console fails with the change, something related to disabling colors? |
|
More backports: #33182. |
But only on AppVeyor, right? The test in question is green on my Mac. 😕 |
e9b9035 to
2588c7d
Compare
2588c7d to
9e6512b
Compare
|
Thank you @derrabus. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 15, 2019
This PR was merged into the 5.0-dev branch. Discussion ---------- [VarDumper] Add parameter type declarations | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A Commits ------- 9e6512b [VarDumper] Add parameter type declarations.
chalasr
added a commit
that referenced
this pull request
Aug 16, 2019
This PR was merged into the 4.3 branch. Discussion ---------- [Console] Fix incomplete output mock | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A Backport from #33153. Merging this up should fix the broken tests on 4.4 and master. Commits ------- 6ecbcf6 [Console] Fix incomplete output mock.
nicolas-grekas
added a commit
that referenced
this pull request
Aug 16, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [VarDumper] Add types to private methods | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A backport from #33153 Commits ------- 065acc8 [VarDumper] Add types to private methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.