[Config] Add more type-hints as follow-up of #32201 #32287
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b69087 to
467b59e
Compare
jschaedl
commented
Jun 29, 2019
| { | ||
| if (!\is_callable($callback)) { | ||
| throw new \InvalidArgumentException(sprintf('Invalid type for callback argument. Expected callable, but got "%s".', \gettype($callback))); | ||
| } |
There was a problem hiding this comment.
With the callable type-hint we will get a TypeError now. So no need to check the argument anymore.
jschaedl
commented
Jun 29, 2019
| * @expectedException \InvalidArgumentException | ||
| * @expectedExceptionMessage Invalid type for callback argument. Expected callable, but got "object". | ||
| */ | ||
| public function testCacheWithInvalidCallback() |
There was a problem hiding this comment.
This test didn't make sense anymore, thanks to the callable type-hint of the callback argument.
derrabus
approved these changes
Jun 29, 2019
|
Closing in favor of #32286 as there is much more missing. But thanks for following up so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Tobion pointed out I missed some type hints in #32201
This PR should fix this.