8000 [Mailer] Fix timeout type hint by fabpot · Pull Request #32210 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] Fix timeout type hint #32210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

[Mailer] Fix timeout type hint #32210

merged 1 commit into from
Jun 27, 2019

Conversation

fabpot
Copy link
Member
@fabpot fabpot commented Jun 27, 2019 •
edited
Loading
Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

The timeout on a socket is a float, not an integer.

@fabpot fabpot added the Mailer label Jun 27, 2019
@fabpot fabpot added this to the 4.3 milestone Jun 27, 2019
@fabpot fabpot merged commit 0e7ed9e into symfony:4.3 Jun 27, 2019
fabpot added a commit that referenced this pull request Jun 27, 2019
@fabpot
bug #32210 [Mailer] Fix timeout type hint (fabpot)
791a212 
This PR was merged into the 4.3 branch.

Discussion
----------

[Mailer] Fix timeout type hint

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The timeout on a socket is a float, not an integer.

Commits
-------

0e7ed9e [Mailer] fixed timeout type hint
@fabpot fabpot deleted the mailer-socket-timeout branch July 18, 2019 20:17
@fabpot fabpot mentioned this pull request Jul 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Mailer Status: Needs Review
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@fabpot @carsonbot
0