[Routing] Add type-hints RequestContext and Route classes. #32181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
commented
Jun 26, 2019
6a69605 to
cece78c
Compare
derrabus
commented
Jun 26, 2019
derrabus
commented
Jun 26, 2019
57 tasks
Tobion
reviewed
Jun 26, 2019
Tobion
reviewed
Jun 26, 2019
Tobion
reviewed
Jun 26, 2019
Tobion
reviewed
Jun 26, 2019
cece78c to
d321a1a
Compare
Tobion
reviewed
Jun 28, 2019
| */ | ||
| public function mount($prefix, self $builder) | ||
| public function mount(string $prefix, self $builder) |
There was a problem hiding this comment.
prefix is a string here but could also be null in
which would currently break.but the prefix handling in this class seems strange anyway.
mount will make the prefix an empty string when prefix is / (the default). but in
it checks for null. IMO the prefix should be initalized as string and then checked for '' instead.
but I would ask you to not add types in RouteCollectionBuilder because I proposed to deprecate it in #32240
this way we can merge this now and decide later if we need to worry about all those edge-cases
Tobion
added a commit
that referenced
this pull request
Jun 28, 2019
…rrabus) This PR was merged into the 4.4 branch. Discussion ---------- [Routing] Deprecate RouteCollection::addPrefix(null) | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR deprecates the undocumented possibility to pass `null` as prefix to `RouteCollection::addPrefix()`. This allows us to add a `string` type-hint on the parameter in 5.0, see #32181 (comment) /cc @Tobion Commits ------- 2a88752 [Routing] Deprecate RouteCollection::addPrefix(null).
|
Please rebase, remove deprecations and revert RouteCollectionBuilder |
d321a1a to
bb0725f
Compare
bb0725f to
614e824
Compare
|
Done. |
Tobion
approved these changes
Jun 28, 2019
|
Thanks Alexander. |
Tobion
added a commit
that referenced
this pull request
Jun 28, 2019
…s. (derrabus) This PR was merged into the 5.0-dev branch. Discussion ---------- [Routing] Add type-hints RequestContext and Route classes. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32179 | License | MIT | Doc PR | N/A This PR adds type-hints to `RequestContext` and the Route classes to give them a more php7-like feeling. Adding these type-hints on master should not be a breaking change because we require php 7.2 there, which allows downstream classes/interfaces to remove a type-hint from a method signature. Commits ------- 614e824 [Routing] Add type-hints RequestContext and Route classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds type-hints to
RequestContextand the Route classes to give them a more php7-like feeling. Adding these type-hints on master should not be a breaking change because we require php 7.2 there, which allows downstream classes/interfaces to remove a type-hint from a method signature.