8000 [PropertyInfo] Extract property type from property declaration by tsantos84 · Pull Request #31798 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[PropertyInfo] Extract property type from property declaration #31798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

[PropertyInfo] Extract property type from property declaration #31798

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4baeb0c
[PropertyInfo] Extract type from property declaration
tsantos84 Jun 2, 2019
e903eeb
[PropertyInfo] Add PHP 7.4-dev to travisci
tsantos84 Jun 2, 2019
e71852d
[PropertyInfo] Change log note
tsantos84 Jun 2, 2019
550c4d2
[PropertyInfo] Change variable name
tsantos84 Jun 2, 2019
afaea21
[PropertyInfo] Remove callable from tests
tsantos84 Jun 7, 2019
d11d8f0
[PropertyInfo] Add copyright text
tsantos84 Jun 7, 2019
f2b5c1a
[PropertyInfo] Add test case for iterable type
tsantos84 Jun 7, 2019
72ee401
[PropertyInfo] Add `self` and `parent` type
tsantos84 Jun 7, 2019
2a273c1
[PropertyInfo] Prevent exception in case the property doesn't exist
tsantos84 Jun 7, 2019
4e5bfe1
[PropertyInfo] Fix code standard
tsantos84 Jun 7, 2019
2f8b2fe
[PropertyInfo] Fix PHP version comparison
tsantos84 Jun 7, 2019
7f1095d
[PropertyInfo] Unifying $reflector argument to keep code cleaner
tsantos84 Jun 7, 2019
92e8be6
[PropertyInfo] Fix code standard
tsantos84 Jun 7, 2019
d6c3e5a
[PropertyInfo] Remove typehint for $resolver argument
tsantos84 Jun 8, 2019
bc8d70c
[PropertyInfo] Change exception
tsantos84 Jun 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[PropertyInfo] Prevent exception in case the property doesn't exist
  • Loading branch information
@tsantos84
tsantos84 committed Jun 7, 2019
commit 2a273c11bf03dca98d09557dd741710d057df834
2 changes: 1 addition & 1 deletion src/Symfony/Component/PropertyInfo/Extractor/ReflectionExtractor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ private function extractFromDeclaredType(string $class, string $property)

try {
$reflectionClass = new \ReflectionClass($class);
$reflectionProperty = $reflectionClass->getProperty($property);
} catch (\ReflectionException $e) {
return null;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent test fails you can add following code here:

if (!$reflectionClass->hasProperty($property)) {
    return null;
}

Copy link
@mshavliuk mshavliuk Jun 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can expand try-catch block for the whole function content (to prevent errors, which can happen while calling hasType, getProperty, getType etc. which can throw ReflectionException).
I think the best option - add either hasProperty or expand try-catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used the same try/catch block where I create the reflection class to get the property, and if it doesn't exist, it'll return null

$reflectionProperty = $reflectionClass->getProperty($property);

if (!$reflectionProperty->hasType()) {
return null;
Expand Down
0