8000 [Form] Remove the scale argument of the IntegerToLocalizedStringTransformer by yceruto · Pull Request #31706 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Remove the scale argument of the IntegerToLocalizedStringTransformer #31706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 29, 2019
Merged

[Form] Remove the scale argument of the IntegerToLocalizedStringTransformer #31706

merged 1 commit into from
May 29, 2019

Conversation

yceruto
Copy link
Member
@yceruto yceruto commented May 29, 2019
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

See #28569

@yceruto yceruto requested a review from xabbuh as a code owner May 29, 2019 19:08
@nicolas-grekas nicolas-grekas added this to the 5.0 milestone May 29, 2019
@yceruto yceruto force-pushed the rm_form_depr4 branch 2 times, most recently from 17028df to 4ff63b9 Compare May 29, 2019 19:15
@nicolas-grekas
Copy link
Member

(another rebase needed :) )

@yceruto
Copy link
Member Author
yceruto commented May 29, 2019

this is the last one for now :)

@nicolas-grekas
Copy link
Member

Thank you @yceruto.

@nicolas-grekas nicolas-grekas merged commit 2cef8a2 into symfony:master May 29, 2019
nicolas-grekas added a commit that referenced this pull request May 29, 2019
@nicolas-grekas
minor #31706 [Form] Remove the scale argument of the IntegerToLocaliz…
7d78252 
…edStringTransformer (yceruto)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Remove the scale argument of the IntegerToLocalizedStringTransformer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See #28569

Commits
-------

2cef8a2 Remove the scale argument of the IntegerToLocalizedStringTransformer
@yceruto yceruto deleted the rm_form_depr4 branch May 29, 2019 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Form Status: Needs Review
Projects
None yet 448E
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yceruto @nicolas-grekas @carsonbot
0