8000 [Messenger] Fix missing auto_setup for RedisTransport by chalasr · Pull Request #31621 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Fix missing auto_setup for RedisTransport #31621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2019
Merged

[Messenger] Fix missing auto_setup for RedisTransport #31621

merged 1 commit into from
May 27, 2019

Conversation

chalasr
Copy link
Member
@chalasr chalasr commented May 25, 2019
Q A
Branch? 4.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Should be my last PR for messenger 4.3's Redis transport :)
Not having it makes it inconsistent with other transports and is especially annoying in tests.

@chalasr chalasr added this to the 4.3 milestone May 25, 2019
@chalasr chalasr force-pushed the msg-redis-autosetup branch from 07fa05b to e9a44e6 Compare May 26, 2019 13:41
@chalasr chalasr force-pushed the msg-redis-autosetup branch from e9a44e6 to d27bc2a Compare May 26, 2019 13:41
@fabpot
Copy link
Member
fabpot commented May 27, 2019

Thank you @chalasr.

@fabpot fabpot merged commit d27bc2a into symfony:4.3 May 27, 2019
fabpot added a commit that referenced this pull request May 27, 2019
@fabpot
bug #31621 [Messenger] Fix missing auto_setup for RedisTransport (cha…
4c1df8a 
…lasr)

This PR was merged into the 4.3 branch.

Discussion
----------

[Messenger] Fix missing auto_setup for RedisTransport

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Should be my last PR for messenger 4.3's Redis transport :)
Not having it makes it inconsistent with other transports and is especially annoying in tests.

Commits
-------

d27bc2a [Messenger] Fix missing auto_setup for RedisTransport
@chalasr chalasr deleted the msg-redis-autosetup branch May 27, 2019 11:23
@fabpot fabpot mentioned this pull request May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@alexander-schranz alexander-schranz alexander-schranz approved these changes

@maxhelias maxhelias maxhelias approved these changes

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @fabpot @alexander-schranz @maxhelias @carsonbot
0