8000 [Translator] Set sources when extracting strings from php files by Stadly · Pull Request #31249 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Translator] Set sources when extracting strings from php files #31249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2019
Merged

[Translator] Set sources when extracting strings from php files #31249

merged 1 commit into from
May 7, 2019

Conversation

Stadly
Copy link
Contributor
@Stadly Stadly commented Apr 25, 2019
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Set metadata about filenames and line numbers when extracting translatable strings from php files. This PR complements #30909 and #31248, as those PRs implement support for dumping the filenames and line numbers to Po and Qt file formats.

@Stadly
Copy link
Contributor Author
Stadly commented Apr 25, 2019
8000

I don't understand why the test is failing on PHP7.3 I've tested with PHP7.3 locally, and it works fine. Can it have something to do with deps=low?

@nicolas-grekas nicolas-grekas added this to the next milestone Apr 26, 2019
@Stadly
Copy link
Contributor Author
Stadly commented Apr 29, 2019

I don't think the failing build has anything to do with this PR.

@fabpot
Copy link
Member
fabpot commented May 2, 2019

@Stadly I see that yo merge a branch here. Can you rebase to get rid of the merge commit?

@Stadly Stadly requested review from dunglas, sroze and xabbuh as code owners May 2, 2019 07:22
@Stadly
Copy link
Contributor Author
Stadly commented May 2, 2019

Haha. I'm messing up everything. I'll try to fix it :)

@fabpot
Copy link
Member
fabpot commented May 2, 2019

One last question about this PR: we set the filename as an absolute path. Is it useful? Wouldn't it be "better" to use a relative path? I'm not sure what the spec says about this.

@Stadly
Copy link
Contributor Author
Stadly commented May 2, 2019

The path used when extracting is the one set as source, so whether it is absolute or relative depends on the user. extract(__DIR__.'/../src/') will give absolute paths, while extract('../src/') will give relative paths.

@Stadly
Copy link
Contributor Author
Stadly commented May 2, 2019

Should I add a test using relative paths?

@fabpot
Copy link
Member
fabpot commented May 7, 2019

Thank you @Stadly.

@fabpot fabpot merged commit f05d4e4 into symfony:master May 7, 2019
fabpot added a commit that referenced this pull request May 7, 2019
@fabpot
feature #31249 [Translator] Set sources when extracting strings from …
b2f5b8a 
…php files (Stadly)

This PR was squashed before being merged into the 4.3-dev branch (closes #31249).

Discussion
----------

[Translator] Set sources when extracting strings from php files

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Set metadata about filenames and line numbers when extracting translatable strings from php files. This PR complements #30909 and #31248, as those PRs implement support for dumping the filenames and line numbers to Po and Qt file formats.

Commits
-------

f05d4e4 [Translator] Set sources when extracting strings from php files
@Stadly Stadly deleted the extract-sources-php branch May 7, 2019 12:15
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
@javiereguiluz javiereguiluz mentioned this pull request May 10, 2019
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.4 Oct 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@sroze sroze Awaiting requested review from sroze

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature Status: Reviewed Translation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Stadly @fabpot @nicolas-grekas @carsonbot
0