[Validator] add new Timezone validation constraint
#30900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
8e03af4 to
6b6c8d0
Compare
src/Symfony/Component/Validator/Constraints/TimezoneValidator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Validator/Constraints/TimezoneValidator.php
Outdated
Show resolved
Hide resolved
|
Also documentation PR is on its way as well ;) |
jewome62
reviewed
Apr 6, 2019
src/Symfony/Component/Validator/Resources/translations/validators.fr.xlf
Outdated
Show resolved
Hide resolved
TimezoneValidatorTimezone validation constraint
OskarStark
reviewed
Apr 6, 2019
src/Symfony/Component/Validator/Resources/translations/validators.en.xlf
Show resolved
Hide resolved
xabbuh
approved these changes
Apr 6, 2019
src/Symfony/Component/Validator/Constraints/TimezoneValidator.php
Outdated
Show resolved
Hide resolved
f13c04b to
e619668
Compare
fabpot
requested changes
Apr 6, 2019
fabpot
requested changes
Apr 6, 2019
src/Symfony/Component/Validator/Constraints/TimezoneValidator.php
Outdated
Show resolved
Hide resolved
fabpot
approved these changes
Apr 6, 2019
|
Thank you @hhamon. |
fabpot
added a commit
that referenced
this pull request
Apr 6, 2019
…phansys) This PR was merged into the 4.3-dev branch. Discussion ---------- [Validator] add new `Timezone` validation constraint | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | symfony/symfony-docs#11317 Rework of #22262. Commits ------- 536e53f [Validator] add new `Timezone` validation constraint.
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 7, 2019
…onstraint. (hhamon, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Validator] add documentation for the new `Timezone` constraint. This is the documentation related to PR symfony/symfony#30900 Commits ------- 8e33d47 Fixes classification 5ec9159 Fix option ec7bd40 Revert country_code to countryCode 9cbeb75 Fixes options list table c5681bf Add more explanations b37bc78 Minor fixes d564218 Minor fixes ac6282f Listed the geographical zones defined by PHP 135c5ff Minor fixes b0b1498 [Validator] add documentation for the new `Timezone` constraint.
|
do we still consider #22262 (review)? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #22262.