ensure compatibility with older PHPUnit mocks #29934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
xabbuh
commented
Jan 19, 2019
|
|
||
| $this->assertEquals(['a1' => $ac1], $classMetadata2->getAttributesMetadata()); | ||
| $this->assertSame(['a', 'b', 'c'], $ac1->getGroups()); | ||
| $this->assertEquals(['a1' => $ac1], $classMetadata1->getAttributesMetadata()); |
There was a problem hiding this comment.
@dunglas Can you have a look here? Reading the code the previous assertion on $classMetadata2 IMO was wrong and only accidentally worked because of our mock configuration line 62. Can you confirm that the change here is valid?
a309317 to
8780184
Compare
xabbuh
commented
Jan 24, 2019
| /** | ||
| * @dataProvider methodExceptGetProvider | ||
| */ | ||
| public function testSubmitFileWithNamelessForm($method) |
There was a problem hiding this comment.
This test was completely broken and just worked because our mocked form behaved completely different from how a real form would behave. I am looking into a proper fix in a different PR.
e2de9f6 to
73369e7
Compare
xabbuh
commented
Jan 24, 2019
51dfa67 to
0b2546f
Compare
0b2546f to
0d9de7e
Compare
nicolas-grekas
approved these changes
Jan 25, 2019
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 25, 2019
This PR was merged into the 3.4 branch. Discussion ---------- ensure compatibility with older PHPUnit mocks | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 0d9de7e [Form] ensure compatibility with older PHPUnit mocks
fabpot
added a commit
that referenced
this pull request
Feb 12, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] add back test after fixing it | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29934 (comment) | License | MIT | Doc PR | Commits ------- 0daeba8 add back test after fixing it
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Feb 12, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [Form] add back test after fixing it | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#29934 (comment) | License | MIT | Doc PR | Commits ------- 0daeba8e8a add back test after fixing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.