8000 [DI] compute autowiring error messages lazily by nicolas-grekas · Pull Request #29108 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DI] compute autowiring error messages lazily #29108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2018
Merged

[DI] compute autowiring error messages lazily #29108

merged 1 commit into from
Dec 13, 2018

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29019
License MIT
Doc PR -

As suggested in the linked issue:

the error message may ultimately be "hidden" because the definition in question is removed... and so we're doing work unnecessarily.

@nicolas-grekas nicolas-grekas added this to the next milestone Nov 6, 2018
@nicolas-grekas nicolas-grekas mentioned this pull request Nov 6, 2018
Closed
@nicolas-grekas nicolas-grekas force-pushed the di-lazy-errors branch 2 times, most recently from b90172a to d4f407d Compare November 6, 2018 15:11
@nicolas-grekas nicolas-grekas force-pushed the di-lazy-errors branch 4 times, most recently from 614e793 to 8000 2244d79 Compare November 6, 2018 18:58
@nicolas-grekas nicolas-grekas merged commit 3b3a1bd into symfony:master Dec 13, 2018
nicolas-grekas added a commit that referenced this pull request Dec 13, 2018
@nicolas-grekas
feature #29108 [DI] compute autowiring error messages lazily (nicolas…
d12a6d0 
…-grekas)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[DI] compute autowiring error messages lazily

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29019
| License       | MIT
| Doc PR        | -

As suggested in the linked issue:

> the error message may ultimately be "hidden" because the definition in question is removed... and so we're doing work unnecessarily.

Commits
-------

3b3a1bd [DI] compute autowiring error messages lazily
@nicolas-grekas nicolas-grekas deleted the di-lazy-errors branch January 25, 2019 14:27
@weaverryan weaverryan mentioned this pull request Mar 14, 2019
Closed
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019
@fabpot fabpot mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@stloyd stloyd stloyd requested changes

@Tobion Tobion Tobion approved these changes

@chalasr chalasr chalasr approved these changes

@dunglas dunglas Awaiting requested review from dunglas

@weaverryan weaverryan Awaiting requested review from weaverryan

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @stloyd @stof @Tobion @chalasr @carsonbot
0