Revert "feature #27801 [MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors" #28845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Oct 13, 2018
fabpot
approved these changes
Oct 13, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 13, 2018
…rface, enabling autoconfiguration of monolog processors" (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- Revert "feature #27801 [MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors" This reverts commit f27c3a8, reversing changes made to 9da0454. | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - A bridge shouldn't provide interfaces to me so I submitted Seldaek/monolog#1204 instead. This PR reverts the possibility to autoconfigure processors for now, so that it could be moved to the MonologBundle instead. To have TokenProcessor and WebProcessor classes implement the new ProcessorInterface, we could bump the minimum version of monolog. This cannot be done until a new version of it is tagged, so we need to resolve this before tagging 4.2 ourselves. Commits ------- cfc3f25 Revert "feature #27801 [MonologBridge] Add ProcessorInterface, enabling autoconfiguration of monolog processors (nicolas-grekas)"
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 9, 2018
This PR was merged into the master branch. Discussion ---------- [Monolog] Move ProcessorInterface to Monolog Since symfony/symfony#27801 was reverted in symfony/symfony#28845 and the new plan being to make this interface part of Monolog. Commits ------- 663f2ea [Monolog] Move ProcessorInterface to Monolog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f27c3a8, reversing
changes made to 9da0454.
A bridge shouldn't provide interfaces to me so I submitted Seldaek/monolog#1204 instead.
This PR reverts the possibility to autoconfigure processors for now, so that it could be moved to the MonologBundle instead.
To have TokenProcessor and WebProcessor classes implement the new ProcessorInterface, we could bump the minimum version of monolog. This cannot be done until a new version of it is tagged, so we need to resolve this before tagging 4.2 ourselves.